Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate k/csi jobs to community cluster #30330

Merged
merged 1 commit into from
Aug 14, 2023
Merged

migrate k/csi jobs to community cluster #30330

merged 1 commit into from
Aug 14, 2023
+72 −56

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Aug 9, 2023

This PR moves the majority of csi jobs from the GCP cluster to the community owned EKS cluster.

ref: #29722

/cc @msau42 @saad-ali @xing-yang @jsafrane @pohly

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Aug 9, 2023
@rjsadow
Copy link
Contributor Author

rjsadow commented Aug 9, 2023

/retest

1 similar comment
@rjsadow
Copy link
Contributor Author

rjsadow commented Aug 10, 2023

/retest

pohly
pohly reviewed Aug 11, 2023
View reviewed changes
config/jobs/kubernetes-csi/gen-jobs.sh Outdated
external-snapshotter|external-resizer|lib-volume-populator|livenessprobe|node-driver-registrar|volume-data-source-validator)
external-snapshotter|external-resizer|lib-volume-populator|livenessprobe|node-driver-registrar|volume-data-source-validator| \
external-health-monitor|external-provisioner|external-attacher|csi-test|csi-release-tools|csi-proxy|csi-lib-utils| \
csi-driver-windows-poc|csi-driver-smb|csi-driver-nvmf|csi-driver-nfs|csi-driver-iscsi|csi-driver-host-path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this now list all (?) or at least a majority of the repos, would it make sense to invert the logic and explicitly list those which don't use eks-prow-build-cluster?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's a much better idea. I'll update.

pohly
pohly reviewed Aug 11, 2023
View reviewed changes
config/jobs/kubernetes-csi/gen-jobs.sh
;;
*)
echo "default"
echo "eks-prow-build-cluster"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it's obvious that we always use the EKS cluster, with no exception.

I can't tell whether that need will ever arise, so let's keep the case switch even though it makes the shell code a bit more complex than (currently!) needed.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 11, 2023
@msau42
Copy link
Member

msau42 commented Aug 14, 2023

/lgtm

@msau42
Copy link
Member

msau42 commented Aug 14, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit b7c6052 into kubernetes:master Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

@rjsadow: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key csi-driver-host-path-config.yaml using file config/jobs/kubernetes-csi/csi-driver-host-path/csi-driver-host-path-config.yaml
  • key csi-driver-iscsi-config.yaml using file config/jobs/kubernetes-csi/csi-driver-iscsi/csi-driver-iscsi-config.yaml
  • key csi-driver-nfs-config.yaml using file config/jobs/kubernetes-csi/csi-driver-nfs/csi-driver-nfs-config.yaml
  • key csi-driver-nvmf-config.yaml using file config/jobs/kubernetes-csi/csi-driver-nvmf/csi-driver-nvmf-config.yaml
  • key csi-driver-windows-poc-config.yaml using file config/jobs/kubernetes-csi/csi-driver-windows-poc/csi-driver-windows-poc-config.yaml
  • key csi-lib-utils-config.yaml using file config/jobs/kubernetes-csi/csi-lib-utils/csi-lib-utils-config.yaml
  • key csi-proxy-config.yaml using file config/jobs/kubernetes-csi/csi-proxy/csi-proxy-config.yaml
  • key csi-proxy-manual-config.yaml using file config/jobs/kubernetes-csi/csi-proxy/csi-proxy-manual-config.yaml
  • key csi-release-tools-config.yaml using file config/jobs/kubernetes-csi/csi-release-tools/csi-release-tools-config.yaml
  • key csi-test-config.yaml using file config/jobs/kubernetes-csi/csi-test/csi-test-config.yaml
  • key external-attacher-config.yaml using file config/jobs/kubernetes-csi/external-attacher/external-attacher-config.yaml
  • key external-health-monitor-config.yaml using file config/jobs/kubernetes-csi/external-health-monitor/external-health-monitor-config.yaml
  • key external-provisioner-config.yaml using file config/jobs/kubernetes-csi/external-provisioner/external-provisioner-config.yaml
  • key external-provisioner-manual-job-config.yaml using file config/jobs/kubernetes-csi/external-provisioner/external-provisioner-manual-job-config.yaml

In response to this:

This PR moves the majority of csi jobs from the GCP cluster to the community owned EKS cluster.

ref: #29722

/cc @msau42 @saad-ali @xing-yang @jsafrane @pohly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rjsadow rjsadow mentioned this pull request Aug 15, 2023
Closed
54 tasks
@rjsadow rjsadow mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly pohly left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@msau42 msau42 Awaiting requested review from msau42

@saad-ali saad-ali Awaiting requested review from saad-ali

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@pohly pohly

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rjsadow @msau42 @k8s-ci-robot @pohly